Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse_owners() #486

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix parse_owners() #486

merged 1 commit into from
Jun 24, 2024

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Jun 24, 2024

parse_owners was erroring with a pydantic validation error because displayName was not being set to fullName because it did actually exist with a value of None. This fixes that scenario

Copy link

sentry-io bot commented Jun 24, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py

Function Unhandled Issue
parse_owner ValidationError: 1 validation error for OwnerRef ...
Event Count: 12

Did you find this useful? React with a 👍 or 👎

@LavMatt LavMatt marked this pull request as ready for review June 24, 2024 13:18
@LavMatt LavMatt requested a review from a team as a code owner June 24, 2024 13:18
@LavMatt LavMatt merged commit 9c8108a into main Jun 24, 2024
4 of 5 checks passed
@LavMatt LavMatt deleted the fix-parse-owner-bug branch June 24, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants