Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove actionable pagination for single page #478

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

tom-webber
Copy link
Contributor

  • remove 'registered by' from search results
  • remove page range if only single page of search results

@tom-webber tom-webber requested a review from a team as a code owner June 21, 2024 13:00
Copy link

sentry-io bot commented Jun 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: home/service/search.py

Function Unhandled Issue
__init__ CatalogueError: Unable to execute facets query /s...
Event Count: 418
__init__ CatalogueError: Unable to execute search query /s...
Event Count: 153

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

@hjribeiro-moj hjribeiro-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-webber tom-webber merged commit 0c12c22 into main Jun 21, 2024
3 of 4 checks passed
@tom-webber tom-webber deleted the FMD-461-no-actionable-pagination-for-1-page branch June 21, 2024 14:00
@tom-webber tom-webber linked an issue Jun 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No actionable pagination if only 1 page of results Drop registered by
2 participants