Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to display #395

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add tags to display #395

merged 4 commits into from
Jun 4, 2024

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Jun 4, 2024

This PR does a couple of things:

  1. It changes the tag used in all search filters from display_in_catalogue to dc_display_in_catalogue
  2. It implements a new property, tags_to_display, in the search_types.SearchResults class. This is populated in a post init and makes a list useing the tags property but excludes any tag with the prefix dc_.

Copy link

sentry-io bot commented Jun 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/datahub-client/data_platform_catalogue/client/search.py

Function Unhandled Issue
search CatalogueError: Unable to execute search query /s...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

@LavMatt LavMatt marked this pull request as ready for review June 4, 2024 13:49
Copy link
Contributor

@MatMoore MatMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. my only question is do we need to separate out tags and tags_to_display? Or can we just replace the existing tags with the filtered list?

@LavMatt
Copy link
Contributor Author

LavMatt commented Jun 4, 2024

Looks good.. my only question is do we need to separate out tags and tags_to_display? Or can we just replace the existing tags with the filtered list?

I thought worth keeping both as we may want to have other dc_ prefixed tags we don't display to users available to use to implement some logic

@LavMatt LavMatt merged commit ae73f80 into main Jun 4, 2024
5 checks passed
@LavMatt LavMatt deleted the add-tags-to-display branch June 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants