add display_in_catalogue tag to filter in search method
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: lib/datahub-client/data_platform_catalogue/client/search.py
Did you find this useful? React with a 👍 or 👎 |
LavMatt
changed the title
display_in_catalogue tag to filter in search method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
display_in_cataloguetag to the filter of every search meaning if that tag is not associated with an entity then that entity will not be returned in search resultsAlso did a bit of housekeeping and fixed some broken tests and added a workflow to run the unit tests specific to our python datahub client library. Must've been missed when the library was moved from data-platform repo
#351