Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a details component with search query tips #293

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Apr 30, 2024

Provide some query examples highlighting some of the supported syntax, and link to the full documentation in Datahub.

This should help mitigate the sometimes unintuitive default behaviour of requiring that ALL search terms match (#248)

This behaviour is how Datahub have configured search, and to change it we would have to customise the Elasticsearch query.

This copy has not been reviewed by a content designer yet - it will probably need another iteration.

Collapsed

Screenshot 2024-04-30 at 15 08 40

Expanded

Screenshot 2024-04-30 at 15 08 46

Provide some query examples highlighting some of the supported syntax,
and link to the full documentation in Datahub.

This should help mitigate the sometimes unintuitive default behaviour of
requiring that ALL search terms match.

This behaviour is how Datahub have configured search, and to change it
we would have to customise the Elasticsearch query.
Copy link
Contributor

@hjribeiro-moj hjribeiro-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit 010b38b into main May 1, 2024
5 checks passed
@MatMoore MatMoore deleted the search-tips branch May 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants