Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change casing of success status #1083

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mitchdawson1982
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 commented Nov 20, 2024

I have noticed that the preprod success slack notification isn't being triggered and I believe that it is a result of the status configuration casing.
I believe the success status needs to match notify_when: success,failure,cancelled,warnings,skipped as per if: github.event.workflow_run.conclusion == 'success'

  with:
    status: Success
    notification_title: Deployment Successful
    message_format: :rocket: <https://preprod.find-moj-data.service.justice.gov.uk/|New Preproduction Deployment>
    footer: Linked Repo <https://github.com/ministryofjustice/find-moj-data|ministryofjustice/find-moj-data> | <https://github.com/ministryofjustice/find-moj-data/actions/runs/|View>
    notify_when: success,failure,cancelled,warnings,skipped
    mention_users_when: success,failure,cancelled,warnings,skipped
    mention_groups_when: success,failure,cancelled,warnings,skipped
    icon_success: :heavy_check_mark:
    icon_failure: :x:
    icon_cancelled: :x:
    icon_warnings: :large_orange_diamond:
    icon_skipped: :fast_forward:
  env:
    SLACK_WEBHOOK_URL: ***

@mitchdawson1982 mitchdawson1982 requested a review from a team as a code owner November 20, 2024 13:29
@mitchdawson1982 mitchdawson1982 merged commit 0375ba3 into main Nov 20, 2024
25 checks passed
@mitchdawson1982 mitchdawson1982 deleted the preprod-deployment-notification-fix branch November 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants