Don't ask for email when reporting issues #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
add-created-by-to-issues
branch
2 times, most recently
from
b954e0b to
b7fa286
Compare
MatMoore
force-pushed
the
add-created-by-to-issues
branch
4 times, most recently
from
3ed1cb9 to
d270ba2
Compare
Instead of requiring the reporter to enter their email, we can just use the email of the currently signed in user. Instead, just ask if they would like to be emailed. I'm using a TypedChoiceField instead of a BooleanField, because BooleanField has weird `required` behaviour. The docs encourage you to set `required=False` if you need to be able to submit a False value, but this means you can't validate that a value was set if you use a RadioWidget.
MatMoore
force-pushed
the
add-created-by-to-issues
branch
from
d270ba2 to
c363b8b
Compare
MatMoore
changed the title
MatMoore
commented
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#995
Instead of requiring the reporter to enter their email, we can just use the email of the currently signed in user.
Instead, just ask if they would like to be emailed.
I'm using a TypedChoiceField instead of a BooleanField, because BooleanField has weird
requiredbehaviour. The docs encourage you to setrequired=Falseif you need to be able to submit a False value, but this means you can't validate that a value was set if you use a RadioWidget.