This repository was archived by the owner on Jan 25, 2022. It is now read-only.
Add support for different docker directory #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,11 @@ | |||
| #DOCKER="/usr/local/bin/docker" | |||
|
|
|||
| # Use DOCKER_OPTS to modify the daemon startup options. | |||
| #DOCKER_OPTS="--dns 8.8.8.8 --dns 8.8.4.4" | |||
| {% if docker.datadir %} | |||
| DOCKER_OPTS="--dns 8.8.8.8 --dns 8.8.4.4 -g {{ docker.datadir }}" | |||
There was a problem hiding this comment.
lets leave the DNS as optional still (leave it commented) and add another line for -g
|
We did this before in the past[1], so I am happy to do it again. 👍 from me [1]: |
ltsampros
force-pushed
the
data-docker-directory
branch
from
bd256c3 to
d66791d
Compare
ltsampros
changed the title
ltsampros
force-pushed
the
data-docker-directory
branch
from
d66791d to
8e58d01
Compare
| # Docker Upstart and SysVinit configuration file | ||
|
|
||
| # Customize location of Docker binary (especially for development testing). | ||
| #DOCKER="/usr/local/bin/docker" | ||
|
|
||
| # Use DOCKER_OPTS to modify the daemon startup options. | ||
| #DOCKER_OPTS="--dns 8.8.8.8 --dns 8.8.4.4" | ||
| {% if docker.datadir %} | ||
| DOCKER_OPTS="-g {{ docker.datadir }}" |
There was a problem hiding this comment.
would it be better append (to the currently empty) variable in case the line above is ever uncommented?
i.e. the line would be
DOCKER_OPTS="${DOCKER_OPTS} -g {{ docker.datadir }}"
It would mean that a change to the DNS options would result in a 1-line diff rather than something larger.
ltsampros
force-pushed
the
data-docker-directory
branch
from
8e58d01 to
77d1dc5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for different docker directory