Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox cloudwatch logs to S3 #6379

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

moj-supratikc
Copy link

@moj-supratikc moj-supratikc commented Dec 19, 2024

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

data-prod has a cloudtrail-athena-events processor that uses a lambda to post logs to a cloudwatch logstream.
This PR replicates this for data-engineering-sandbox-a. The intention is to then extend this with another lambda that writes the logs to S3 on a schedule.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Do Not Merge yet - still being expanded

@moj-supratikc moj-supratikc added do-not-merge Don't merge yet! experiment trying out a thing, without developing a feature labels Dec 19, 2024
@moj-supratikc moj-supratikc requested review from a team as code owners December 19, 2024 16:45
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Terraform Component 🧱: aws-analytical-platform-data-engineering-sandbox-a-cloudtrail-athena-events

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @moj-supratikc, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-engineering-sandbox-a/cloudtrail-athena-events, Workflow: Terraform, Marker: aws-analytical-platform-data-engineering-sandbox-a-cloudtrail-athena-events_static_analysis

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Terraform Component 🧱: aws-analytical-platform-data-engineering-sandbox-a-cloudtrail-athena-events

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @moj-supratikc, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-engineering-sandbox-a/cloudtrail-athena-events, Workflow: Terraform, Marker: aws-analytical-platform-data-engineering-sandbox-a-cloudtrail-athena-events_plan

@moj-supratikc
Copy link
Author

@jhpyke PR submitted as requested. Will expand with the S3 export module when I have some time as well. Thanks for all your help!

@jacobwoffenden jacobwoffenden marked this pull request as draft February 5, 2025 20:18
Copy link
Contributor

github-actions bot commented Mar 8, 2025

This pull reuest is being marked as stale because it has been open for 30 days with no activity. Remove stale label or comment to keep the pull reuest open.

@github-actions github-actions bot added the stale label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Don't merge yet! experiment trying out a thing, without developing a feature stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants