Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize filter priority for deleting and generating image sizes #74

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented Mar 1, 2024

  • Moves the deleting of generated image sizes to priority 5. This way, we make sure that generated image files are not present before other plugins run their filters.
  • Moves generating additional image sizes to priority 30. This way, we make sure that image sizes are generated after other plugins have run their filters.

This pull request can improve compatibility with plugins like TinyPNG. When using a plugin like this, you would only optimize the original image size. All other image sizes will be generated from the original, optimized image.

Moves the deleting of generated image sizes to priority 5. This way, we make sure that generated image files are not present before other plugins run their filters.

Moves generating additional image sizes to priority 30. This way, we make sure that image sizes are generated after other plugins have run their filters.
@gchtr gchtr merged commit b3232c5 into 1.x Mar 4, 2024
20 checks passed
@gchtr gchtr deleted the 1.x-generated-meta-data-priorities branch March 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant