Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix GetValueFromConfig for bool type #39527

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jan 22, 2025

pr: #39526

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 22, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Member

liliu-z commented Jan 22, 2025

rerun cpp-unit-test

Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the fix_GetValueFromConfig_2.5 branch from 7d46ed6 to 3b4dc85 Compare January 22, 2025 13:43
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 22, 2025
@liliu-z
Copy link
Member

liliu-z commented Jan 22, 2025

/lgtm

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (4602e97) to head (3b4dc85).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39527      +/-   ##
==========================================
+ Coverage   80.96%   80.99%   +0.02%     
==========================================
  Files        1404     1404              
  Lines      198004   198008       +4     
==========================================
+ Hits       160322   160368      +46     
+ Misses      32039    32004      -35     
+ Partials     5643     5636       -7     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <100.00%> (+<0.01%) ⬆️
Go 82.95% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/index/Utils.h 100.00% <100.00%> (+11.11%) ⬆️

... and 31 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 22, 2025
@sre-ci-robot sre-ci-robot merged commit 6cdabd9 into milvus-io:2.5 Jan 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants