-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:fix GetValueFromConfig for bool type #39527
fix:fix GetValueFromConfig for bool type #39527
Conversation
@zhagnlu cpp-unit-test check failed, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rerun cpp-unit-test |
Signed-off-by: luzhang <luzhang@zilliz.com>
7d46ed6
to
3b4dc85
Compare
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39527 +/- ##
==========================================
+ Coverage 80.96% 80.99% +0.02%
==========================================
Files 1404 1404
Lines 198004 198008 +4
==========================================
+ Hits 160322 160368 +46
+ Misses 32039 32004 -35
+ Partials 5643 5636 -7
|
pr: #39526