Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] add operate privilege & privilege group API #38141

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shaoting-huang
Copy link
Contributor

related issue: #37031

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (23dc313) to head (4f49476).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38141      +/-   ##
==========================================
+ Coverage   81.06%   81.09%   +0.03%     
==========================================
  Files        1369     1372       +3     
  Lines      190978   191215     +237     
==========================================
+ Hits       154819   155074     +255     
+ Misses      30659    30649      -10     
+ Partials     5500     5492       -8     
Components Coverage Δ
Client 74.43% <100.00%> (+0.76%) ⬆️
Core 68.87% <ø> (ø)
Go 83.22% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
client/milvusclient/rbac.go 100.00% <100.00%> (ø)
client/milvusclient/rbac_options.go 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 2, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 3, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6f1b1ad into milvus-io:master Dec 3, 2024
20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
…io#38141)

related issue: milvus-io#37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
…io#38141)

related issue: milvus-io#37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
…io#38141)

related issue: milvus-io#37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
…io#38141)

related issue: milvus-io#37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@shaoting-huang shaoting-huang deleted the grantv2_client branch February 24, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants