-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Trigger l0 compaction when l0 views don't change #30729
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@XuanYang-cn ut workflow job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30729 +/- ##
==========================================
- Coverage 80.69% 80.42% -0.27%
==========================================
Files 952 962 +10
Lines 137065 137087 +22
==========================================
- Hits 110598 110251 -347
- Misses 22745 23111 +366
- Partials 3722 3725 +3
|
5c87d2f
to
a3234aa
Compare
@XuanYang-cn E2e jenkins job failed, comment |
a3234aa
to
36532f5
Compare
@XuanYang-cn E2e jenkins job failed, comment |
/run-cpu-e2e |
@XuanYang-cn E2e jenkins job failed, comment |
36532f5
to
5d181ad
Compare
@XuanYang-cn E2e jenkins job failed, comment |
/run-cpu-e2e |
@XuanYang-cn E2e jenkins job failed, comment |
So that leftover l0 segments would be compacted in the end. 1. Refresh LevelZero plans in comactionPlanHandler, remove the meta dependency of compaction trigger v2 2. Add ForceTrigger method for CompactionView interface 3. rename mu to taskGuard 4. Add a new TriggerTypeLevelZeroViewIDLE 5. Add an idleTicker for compaction view manager Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
5d181ad
to
bccd65e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Trigger l0 compaction when l0 views don't change
So that leftover l0 segments would be compacted in the end.
of compaction trigger v2
See also: #30098, #30556
Signed-off-by: yangxuan xuan.yang@zilliz.com