Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger l0 compaction when l0 views don't change #30729

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Feb 21, 2024

Trigger l0 compaction when l0 views don't change

So that leftover l0 segments would be compacted in the end.

  1. Refresh LevelZero plans in comactionPlanHandler, remove the meta dependency
    of compaction trigger v2
  2. Add ForceTrigger method for CompactionView interface
  3. rename mu to taskGuard
  4. Add a new TriggerTypeLevelZeroViewIDLE
  5. Add an idleTicker for compaction view manager

See also: #30098, #30556

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 21, 2024
Copy link
Contributor

mergify bot commented Feb 21, 2024

@XuanYang-cn

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@XuanYang-cn XuanYang-cn changed the title Trigger l0 compaction when l0 views don't change fix: Trigger l0 compaction when l0 views don't change Feb 21, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Feb 21, 2024
Copy link
Contributor

mergify bot commented Feb 21, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 96.68874% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.42%. Comparing base (57397b1) to head (bccd65e).
Report is 80 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30729      +/-   ##
==========================================
- Coverage   80.69%   80.42%   -0.27%     
==========================================
  Files         952      962      +10     
  Lines      137065   137087      +22     
==========================================
- Hits       110598   110251     -347     
- Misses      22745    23111     +366     
- Partials     3722     3725       +3     
Files Coverage Δ
internal/datacoord/compaction.go 78.19% <100.00%> (+0.41%) ⬆️
internal/datacoord/compaction_scheduler.go 94.44% <100.00%> (ø)
internal/datacoord/compaction_view.go 78.30% <ø> (ø)
internal/datacoord/server.go 71.18% <100.00%> (ø)
internal/datacoord/compaction_l0_view.go 90.09% <92.85%> (+0.39%) ⬆️
internal/datacoord/compaction_view_manager.go 96.79% <98.50%> (+8.72%) ⬆️
internal/datacoord/compaction_trigger_v2.go 89.77% <93.18%> (+3.85%) ⬆️

... and 219 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 22, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 23, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 23, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 26, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 27, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

So that leftover l0 segments would be compacted in the end.

1. Refresh LevelZero plans in comactionPlanHandler, remove the meta dependency
of compaction trigger v2
2. Add ForceTrigger method for CompactionView interface
3. rename mu to taskGuard
4. Add a new TriggerTypeLevelZeroViewIDLE
5. Add an idleTicker for compaction view manager

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit def7294 into milvus-io:master Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants