Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the merge logic of searchTask #17194

Merged
merged 1 commit into from
May 24, 2022

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented May 24, 2022

fix #17188
Signed-off-by: zhenshan.cao zhenshan.cao@zilliz.com

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 24, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #17194 (907bda2) into master (2512e66) will increase coverage by 0.09%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17194      +/-   ##
==========================================
+ Coverage   80.46%   80.55%   +0.09%     
==========================================
  Files         460      460              
  Lines       72049    72044       -5     
==========================================
+ Hits        57975    58038      +63     
+ Misses      11452    11387      -65     
+ Partials     2622     2619       -3     
Impacted Files Coverage Δ
internal/querynode/query_shard.go 79.03% <ø> (+12.78%) ⬆️
internal/querynode/task_search.go 0.00% <0.00%> (ø)
internal/proxy/task_search.go 61.62% <25.00%> (-0.28%) ⬇️
internal/proxy/util.go 85.71% <50.00%> (-0.52%) ⬇️
internal/distributed/querycoord/client/client.go 70.38% <0.00%> (-1.95%) ⬇️
internal/rootcoord/task.go 76.61% <0.00%> (-1.19%) ⬇️
internal/util/grpcclient/client.go 84.81% <0.00%> (-0.64%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.24% <0.00%> (-0.59%) ⬇️
internal/indexcoord/meta_table.go 83.29% <0.00%> (-0.52%) ⬇️
internal/rootcoord/meta_table.go 82.08% <0.00%> (-0.49%) ⬇️
... and 15 more

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ec1103c into milvus-io:master May 24, 2022
@czs007 czs007 deleted the improve_sq branch July 7, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Simplify the merge logic of searchTask
3 participants