-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds type summary to the generation pipeline #785
Conversation
move the script to correct location update pipeline
Perf note: The script took 43 seconds to run on the V1 repo, which should be OK to have for the added benefit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will really help on the messy metadata changes.
$writer.WriteLine($twoSpaces + "method " + $method.Name) | ||
$writer.WriteLine($fourSpaces + "return type " + (normalize $method.ReturnType.FullName)) | ||
|
||
foreach($param in $method.GetParameters()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does GetParameters()
return the parameters in the order that they are defined? I'd imagine it does but I want to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same assumption given that Reflection is used in places where people can create Invoke methods by following the parameter order.
I couldn't find documentation confirming this, but a quick look revealed that I always get the same order from the definition. I also swapped orders in one of the methods, rebuilt the dll and the only diff was on that parameter order.
So I am fairly confident that this is a deterministic order and it will raise diffs if someone changes the order.
typeSummary.txt
file