Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version in the OpenAPI descriptions is incorrect #275

Closed
baywet opened this issue Feb 20, 2023 · 4 comments
Closed

version in the OpenAPI descriptions is incorrect #275

baywet opened this issue Feb 20, 2023 · 4 comments
Assignees
Labels
metadata-issue An issue with the metadata priority:p3 Nice to close

Comments

@baywet
Copy link
Member

baywet commented Feb 20, 2023

The version field of the OpenAPI description is currently being set to a random number instead of the true version (v1.0|beta).
This is causing issues for indexers and might be confusing to consumers of the description.
We should address this in the generation process to correct that information.

Once this is fixed, please revert to the issue linked to give a heads up to maintainers.

@baywet baywet added metadata-issue An issue with the metadata priority:p3 Nice to close labels Feb 20, 2023
@baywet baywet added this to the Feb-2023 milestone Feb 20, 2023
@irvinesunday
Copy link
Contributor

@baywet this sounds like a conversion issue. Should we move it to the relevant repository?

@baywet
Copy link
Member Author

baywet commented Feb 22, 2023

You are correct, the conversion library reads the information from the odata context.
https://github.com/microsoft/OpenAPI.NET.OData/blob/a8d815a19f8feae41c55fc66779d25d26ef7eb78/src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiInfoGenerator.cs#L29

And that comes from the version in the convert settings.

https://github.com/microsoft/OpenAPI.NET.OData/blob/a8d815a19f8feae41c55fc66779d25d26ef7eb78/src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs#L28

Transferring.
(once the fix is implemented, we'll need to update the conversion settings)

@baywet
Copy link
Member Author

baywet commented Feb 22, 2023

I'm not powerful enough to transfer between orgs. closing this and will reopen on the other side.

@baywet
Copy link
Member Author

baywet commented Feb 22, 2023

created this microsoft/OpenAPI.NET.OData#346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-issue An issue with the metadata priority:p3 Nice to close
Projects
None yet
Development

No branches or pull requests

2 participants