Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OpenAPI version field is not limited to dotnet version specs #346

Closed
5 of 6 tasks
baywet opened this issue Feb 22, 2023 · 2 comments · Fixed by #360
Closed
5 of 6 tasks

The OpenAPI version field is not limited to dotnet version specs #346

baywet opened this issue Feb 22, 2023 · 2 comments · Fixed by #360
Assignees
Labels
priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Feb 22, 2023

The dotnet version type is limited to four numeric values (W.X.Y.Z)
However the version spec for OpenAPI is just a string, so it can support more advanced patterns like semver.

original issue

We need to update the convert settings to do a couple of things:

  • add a SemVerVersion (string) property.
  • default it to 1.0.0
  • replace the clone implementation to use that field instead.
  • update the reader to use that field instead.
  • mark the version field as obsolete.
  • change the version field to simply be a getter and a setter that reads and write to the SemVerVersion field instead.

Once all of that is built and shipped, update the generation pipeline to put the correct versions, and give a heads up to the community

@baywet baywet added type:bug A broken experience priority:p3 Nice to have. Customer impact is very minimal labels Feb 22, 2023
@baywet baywet added this to the OData:1.3 milestone Feb 22, 2023
@baywet baywet added priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days and removed priority:p3 Nice to have. Customer impact is very minimal labels Feb 22, 2023
@irvinesunday
Copy link
Contributor

@baywet what clone implementation are you referring to?

@baywet
Copy link
Member Author

baywet commented Mar 22, 2023

The one in convert settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days type:bug A broken experience
Projects
None yet
2 participants