Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/source-build-reference-packages #4589

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 3, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: af712b65-5e6e-4ab3-9c28-08db4c03ab45
  • Build: 20230706.4
  • Date Produced: July 6, 2023 9:26:41 PM UTC
  • Commit: 81a9aad6994047fc0e589a82597d1d8c179f22bd
  • Branch: refs/heads/main

dotnet-maestro bot added 2 commits July 3, 2023 13:00
…ence-packages build 20230630.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23323.1 -> To Version 8.0.0-alpha.1.23330.2
…ence-packages build 20230706.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23323.1 -> To Version 8.0.0-alpha.1.23356.4
@Evangelink
Copy link
Member

@MichaelSimons Do you have any idea why this bump is causing an issue on NuGet.Frameworks:

1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
NuGet.Frameworks.6.5.0

I would have assumed this PR #4532 or this one #4512 to be causing an issue but not this bump.

@MichaelSimons
Copy link
Member

This package was recently cleaned up from SBRP because it is not being referenced in the full product build. We want SBRP to only contain the ref packages needed in the full product build not just the repo level source-builds. When vstest builds in the product source-build, it's NuGet version gets lifted to the latest because of the presence of a Versions.Details.xml dependency. When building the repo source-build leg, it uses the version declared in the repo because the rest of the product was not just built.

As a result this prebuilt should be added as an allowed prebuilt in https://github.com/microsoft/vstest/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

@Evangelink Evangelink requested a review from MichaelSimons July 10, 2023 20:03
@Evangelink
Copy link
Member

@MichaelSimons Thanks for the information! As requested in the past, please review the change.

@Evangelink Evangelink merged commit d781dc0 into main Jul 11, 2023
@Evangelink Evangelink deleted the darc-main-7cb6dc2f-9314-4ce8-be0a-a8769a174789 branch July 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants