Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linkes to all RFCs #1743

Merged
merged 5 commits into from
Sep 11, 2018
Merged

Added linkes to all RFCs #1743

merged 5 commits into from
Sep 11, 2018

Conversation

pvlakshm
Copy link
Contributor

Added links to all RFCs to address #1392.

Added links to all RFCs to address #1392.
@pvlakshm pvlakshm requested a review from singhsarab August 21, 2018 18:40
README.md Outdated
@@ -25,6 +25,21 @@ There are many ways to contribute to VSTest
- [Data collection Protocol](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0006-DataCollection-Protocol.md)
- [Translation Layer](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0008-TranslationLayer.md)
- [Editors API Revision Update](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0009-Editors-API-RevisionUpdate.md)
- [TranslationLayer](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0008-TranslationLayer.md)
- [Source-Information-For-Discovered-Tests](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0010-Source-Information-For-Discovered-Tests.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid "-" just for better readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-" is for getting it rendered as a list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the name pratap sir.

README.md Outdated
- [Skip-Default-Adapters](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0018-Skip-Default-Adapters.md)
- [Disable-Appdomain-While-Running-Tests](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0019-Disable-Appdomain-While-Running-Tests.md)
- [Improving-Logic-To-Pass-Sources-To-Adapters](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0020-Improving-Logic-To-Pass-Sources-To-Adapters.md)
- [CodeCoverageForNetCore](https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0021-CodeCoverageForNetCore.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Expand the Title for this one.

@mmitche
Copy link
Member

mmitche commented Sep 4, 2018

@dotnet-bot test this please

@singhsarab
Copy link
Contributor

@dotnet-bot test Ubuntu14.04 / Release Build

@singhsarab
Copy link
Contributor

@dotnet-bot test Ubuntu14.04 / Debug Build

@singhsarab singhsarab merged commit 4d89670 into master Sep 11, 2018
smadala pushed a commit to smadala/vstest that referenced this pull request Oct 5, 2018
Added links to all RFCs to address microsoft#1392.

* refined link test to .NET Core CC RFC.

* Update README.md

(cherry picked from commit 4d89670)
@smadala smadala mentioned this pull request Oct 5, 2018
smadala added a commit that referenced this pull request Oct 8, 2018
* Verify NS.JSon is loaded appropriately in case of DisableAppDomain (#1740)

* reverting back app domain culture setup

* binding redirect for TW.Interfaces

* Run net451 test for Newtonsoft dependency

(cherry picked from commit 3cbab0b)

* Run tests only for test projects (#1745)


(cherry picked from commit a2b4196)

* Upgrading the version of VSSDK Build tools nuget, because the older one is incompatible with the latest VSSDK. (#1761)


(cherry picked from commit d391224)

* Added linkes to all RFCs (#1743)

Added links to all RFCs to address #1392.

* refined link test to .NET Core CC RFC.

* Update README.md

(cherry picked from commit 4d89670)

* Get latest extensions from VS d15.9stg branch (#1771)


(cherry picked from commit d5c4415)

* Add info log if try to run tests with no IsTestProject prop (#1778)

* Add info log if try to run tests with no IsTestProject prop

* Add message to resources

* invert check

(cherry picked from commit 3decca0)
@singhsarab singhsarab deleted the pvlakshm-patch-1 branch November 8, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants