Fix datacollectors temporary files cleanup. #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
changed the title
acesiddhu
reviewed
Mar 16, 2018
| } | ||
|
|
||
| if (EqtTrace.IsVerboseEnabled) | ||
| { |
There was a problem hiding this comment.
To avoid new string allocation.
acesiddhu
reviewed
Mar 16, 2018
|
|
||
| RemoveDataCollectors(new List<DataCollectorInformation>(this.RunDataCollectors.Values)); | ||
|
|
||
| EqtTrace.Info("DataCollectionManager.CleanupPlugins: CleanupPlugins finished"); |
There was a problem hiding this comment.
EqtTrace.Info [](start = 12, length = 13)
why not here then
There was a problem hiding this comment.
This is compile time string. already created.
acesiddhu
reviewed
Mar 16, 2018
| } | ||
|
|
||
| this.disposed = true; | ||
| } | ||
| } | ||
|
|
||
| private void CleanupPlugins() | ||
| { | ||
| EqtTrace.Info("DataCollectionManager.CleanupPlugins: CleanupPlugins called"); |
There was a problem hiding this comment.
Info [](start = 21, length = 4)
and here
|
@dotnet-bot please test Windows_NT / Debug Build |
|
@dotnet-bot please test Windows_NT / Release Build |
1 similar comment
|
@dotnet-bot please test Windows_NT / Release Build |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue
microsoft/azure-pipelines-tasks#6694
microsoft/testfx#354 (comment)