Use ICodeMapperService for 'Apply In Editor' #237509
Conversation
| codeMapper = provider.displayName; | ||
| progress.report({ message: localize('applyCodeBlock.progress', "Applying code block using {0}...", codeMapper) }); | ||
| const mappedEdits = await provider.provideMappedEdits( | ||
| activeModel, |
There was a problem hiding this comment.
Does this mean MappedEditsProvider.provideMappedEdits is deprecated? I don't see a comment on the public (proposed) API but AFAICT, provideMappedEdits is no longer called when not using MappedEditsProvider2.
I'm trying to fix some Conversation Request bug I've come across, but now the API appears completely disconnected.
There was a problem hiding this comment.
Oh, sorry, I thought we were the only users and implementors.
Yes, we want to deprecate MappedEditsProvider in favor of MappedEditsProvider2 as this one is streaming the results.
I'll add the 'deprecated' comments shortly.
Let me know if you prefer me to still check for the MappedEditsProvider if MappedEditsProvider2 is unavailable.
There was a problem hiding this comment.
No worries, we took a look at MappedEditsProvider2 and are happy to migrate to it. Thanks for the clarity on your plans + the forthcoming deprecated comments.
I believe said bug will still reproduce, but at least my to-be-filed issue and PR will target the correct feature.
Fixes https://github.com/microsoft/vscode-copilot/issues/11491