Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 227150: Added a recursive git clone button #232497

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Parasaran-Python
Copy link
Contributor

@Parasaran-Python Parasaran-Python commented Oct 29, 2024

fix #227150 : Added a recursive git clone button

@Parasaran-Python Parasaran-Python changed the title fix #227150, doing a recurse git clone instead of regular clone to cl… fix #227150, doing a recurse git clone instead of regular clone to clone the submodules as well Oct 29, 2024
@Parasaran-Python
Copy link
Contributor Author

Parasaran-Python commented Oct 29, 2024

Hello @lszomoru can you please review this?

Thanks.

@Parasaran-Python Parasaran-Python changed the title fix #227150, doing a recurse git clone instead of regular clone to clone the submodules as well fix #227150, doing a recursive git clone instead of regular clone to clone the submodules as well Oct 31, 2024
@Parasaran-Python Parasaran-Python force-pushed the 227150 branch 2 times, most recently from a3dbf65 to bd4285a Compare November 4, 2024 04:59
@Parasaran-Python
Copy link
Contributor Author

Hello @lszomoru can you please check this PR when you have a moment?

@Parasaran-Python Parasaran-Python force-pushed the 227150 branch 2 times, most recently from 2a17e57 to 4e081fb Compare November 13, 2024 16:56
@Parasaran-Python
Copy link
Contributor Author

@lszomoru following up for a review 🙂

@Parasaran-Python Parasaran-Python force-pushed the 227150 branch 2 times, most recently from 4fe9c62 to 11d3066 Compare December 1, 2024 08:45
@lszomoru lszomoru added the git GIT issues label Dec 1, 2024
@Parasaran-Python
Copy link
Contributor Author

Greetings @lszomoru , is there something missing in this PR due to which it has been kept on hold?🙂

@lszomoru
Copy link
Member

Thanks for submitting the PR. Here are my comments:

  • We should not change the behaviour of the Clone button but add a second button for the Clone (recursive) action
  • We should not change the behaviour of the Clone button in the walkthrough as that is targeted to new users

@Parasaran-Python
Copy link
Contributor Author

Thanks @lszomoru for your time, will review

The key take away is just add a new recursive clone button here

git-clone-button.png

And no other change apart from this.

Please confirm this understanding of mine.

@lszomoru
Copy link
Member

Correct. Add a new button "Clone Repository (Recursive)".

@Parasaran-Python
Copy link
Contributor Author

Thanks for confirming, will do this ASAP.

@Parasaran-Python
Copy link
Contributor Author

Parasaran-Python commented Dec 10, 2024

image

@lszomoru while I have incorporated the suggestion and it works fine.

Was wondering if the cloning progress notification needs to undergo a text change?

may be "(recursive)" can be added? Not sure if this would make things a bit wordy.

image

@Parasaran-Python Parasaran-Python changed the title fix #227150, doing a recursive git clone instead of regular clone to clone the submodules as well fix 227150: Added a recursive git clone button Dec 11, 2024
@Parasaran-Python Parasaran-Python force-pushed the 227150 branch 2 times, most recently from 35452c4 to dab2be4 Compare December 13, 2024 17:14
@Parasaran-Python
Copy link
Contributor Author

@lszomoru could you please take a look at the changes when you have a moment.

@Parasaran-Python
Copy link
Contributor Author

Hello @lszomoru could you please go through this and let me know if you have any suggestions. 🙂

@Parasaran-Python
Copy link
Contributor Author

Hello @lszomoru following up for a re-review 🙂

@lszomoru
Copy link
Member

lszomoru commented Jan 9, 2025

@Parasaran-Python, sorry for not getting back to you on this until now. I have been thinking a little bit more about this and since the "Clone" button should be as "general purpose" as possible, I think that it is fine to update the command of the "Clone" button instead of adding a new one.

@lszomoru lszomoru enabled auto-merge (squash) January 9, 2025 10:07
@lszomoru lszomoru added this to the January 2025 milestone Jan 9, 2025
@lszomoru lszomoru merged commit 0c176cf into microsoft:main Jan 9, 2025
7 checks passed
@Parasaran-Python Parasaran-Python deleted the 227150 branch January 11, 2025 18:33
@Parasaran-Python Parasaran-Python restored the 227150 branch January 11, 2025 18:33
@Parasaran-Python Parasaran-Python deleted the 227150 branch January 11, 2025 18:33
@Parasaran-Python Parasaran-Python restored the 227150 branch January 11, 2025 18:33
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git - Submodules are not processed when cloning a git project.
3 participants