-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 227150: Added a recursive git clone button #232497
Conversation
3e165fc
to
ef4ce0f
Compare
Hello @lszomoru can you please review this? Thanks. |
ef4ce0f
to
1da6ca0
Compare
a3dbf65
to
bd4285a
Compare
Hello @lszomoru can you please check this PR when you have a moment? |
2a17e57
to
4e081fb
Compare
@lszomoru following up for a review 🙂 |
4fe9c62
to
11d3066
Compare
Greetings @lszomoru , is there something missing in this PR due to which it has been kept on hold?🙂 |
11d3066
to
06a6a41
Compare
Thanks for submitting the PR. Here are my comments:
|
Thanks @lszomoru for your time, will review The key take away is just add a new recursive clone button here And no other change apart from this. Please confirm this understanding of mine. |
Correct. Add a new button "Clone Repository (Recursive)". |
Thanks for confirming, will do this ASAP. |
06a6a41
to
7d69a1c
Compare
@lszomoru while I have incorporated the suggestion and it works fine. Was wondering if the cloning progress notification needs to undergo a text change? may be "(recursive)" can be added? Not sure if this would make things a bit wordy. |
35452c4
to
dab2be4
Compare
@lszomoru could you please take a look at the changes when you have a moment. |
dab2be4
to
5478003
Compare
5478003
to
f4f4dc1
Compare
Hello @lszomoru could you please go through this and let me know if you have any suggestions. 🙂 |
Hello @lszomoru following up for a re-review 🙂 |
@Parasaran-Python, sorry for not getting back to you on this until now. I have been thinking a little bit more about this and since the "Clone" button should be as "general purpose" as possible, I think that it is fine to update the command of the "Clone" button instead of adding a new one. |
fix #227150 : Added a recursive git clone button