Fix HC textPreformat colors #214487
Merged
Fix HC textPreformat colors #214487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
approved these changes
Jun 6, 2024
Tyriar
approved these changes
Jun 6, 2024
daviddossett
added
the
candidate
|
I agree this should be a candidate, make sure you set the labels and milestone on the issue too. I ran across it in #214494 |
daviddossett
added a commit
that referenced
this pull request
Jun 7, 2024
Fix HC textPreformat colors
benibenj
pushed a commit
that referenced
this pull request
Jun 11, 2024
Merge pull request #214487 from microsoft/ddossett/rainy-mockingbird Fix HC textPreformat colors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214412
I originally reversed these colors in #213698 to address an issue with invisible shortcuts in the editor playground.
Seems like
textPreformat.foregroundneeds to be used withtextPreformat.backgroundto be visible.