-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add go to symbol in the accessible view #189575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an ok approach to me. I've also copied @jrieken I believe he's worked more with go to symbol
quickPick.items = symbols; | ||
quickPick.show(); | ||
quickPick.onDidAccept(() => { | ||
this._accessibleView.showSymbol(provider, quickPick.selectedItems[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't going to dismiss the quick pick. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepting one does because of the focus change. escaping the quick pick wasn't handled, but now is #189658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a setting called ignoreFocusOut that won't close the quick pick when focus is lost.
As a result this qp won't go away with that setting. I recommend explicitly closing it
demo.mov
fixes #188702
@mjbvz since the accessible view is not attached to an editor pane, the default language features won't work here - thus, this code.
the idea is most of the time the language will be
markdown
. when it's not, we defer to the provider for symbols IE quick pick items.vscode/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
Lines 190 to 195 in a1f77aa
vscode/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
Line 223 in a1f77aa
do you have a suggestion for a better / more performant / more precise approach?