chore: revert to Electron 19 #175851
Merged
chore: revert to Electron 19 #175851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for validating: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=205094&view=results |
deepak1556
force-pushed
the
robo/revert_electron_22
branch
from
29e6dc7 to
307dedd
Compare
|
Build is looking good, I will make the distro change in a follow-up PR. |
bpasero
approved these changes
Mar 2, 2023
deepak1556
added a commit
that referenced
this pull request
Mar 3, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 3, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 19, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 21, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 22, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 22, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 23, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 25, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Mar 31, 2023
This reverts commit 3a11b47.
deepak1556
added a commit
that referenced
this pull request
Apr 3, 2023
This reverts commit 3a11b47.
bpasero
added a commit
that referenced
this pull request
Apr 3, 2023
* Revert "chore: revert to Electron 19 (#175851)" This reverts commit 3a11b47. * chore: bump electron@22.3.3 * build: use custom version for V8 sandbox * chore: update electron@22.4.1 * chore: enable forceAllocationsToV8Sandbox for extension host * chore: bump electron@22.4.2 * chore: bump electron@22.4.3 * temp: update distro * sandbox - cleanup from electron 22 update * missing comile * more changes * fix build * restore * 💄 * compile --------- Co-authored-by: deepak1556 <hop2deep@gmail.com>
bpasero
added a commit
that referenced
this pull request
Apr 3, 2023
* Revert "chore: revert to Electron 19 (#175851)" This reverts commit 3a11b47. * chore: bump electron@22.3.3 * build: use custom version for V8 sandbox * chore: update electron@22.4.1 * chore: enable forceAllocationsToV8Sandbox for extension host * chore: bump electron@22.4.2 * chore: bump electron@22.4.3 * sandbox - cleanup from electron 22 update (#178919) * Revert "chore: revert to Electron 19 (#175851)" This reverts commit 3a11b47. * chore: bump electron@22.3.3 * build: use custom version for V8 sandbox * chore: update electron@22.4.1 * chore: enable forceAllocationsToV8Sandbox for extension host * chore: bump electron@22.4.2 * chore: bump electron@22.4.3 * temp: update distro * sandbox - cleanup from electron 22 update * missing comile * more changes * fix build * restore * 💄 * compile --------- Co-authored-by: deepak1556 <hop2deep@gmail.com> --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert until #175843 is resolved.