Initial implementation of Continue Edit Session #151528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache preferred session ID on disk and reuse it silently if available
Only deal with file contents for now
joyceerhl
commented
Jun 8, 2022
src/vs/workbench/contrib/sessionSync/browser/sessionSync.contribution.ts
Show resolved
Hide resolved
joyceerhl
commented
Jun 8, 2022
src/vs/workbench/services/sessionSync/browser/sessionSyncWorkbenchService.ts
Show resolved
Hide resolved
bpasero
reviewed
Jun 8, 2022
There was a problem hiding this comment.
@joyceerhl fyi if a new service is only being used from contrib, then the service can also be registered from there. Please look at Tylers PR where this was addressed recently too:
Also be careful when registering from workbench.common.main and workbench.web.main because the one depends on the other. If the same things are used in web and desktop, only use common.main, otherwise use the web and sandbox specifics.
|
@bpasero thanks for the tip! I added a note on that to https://github.com/microsoft/vscode/wiki/Source-Code-Organization#workbench-contrib |
|
Thanks, looks good now! |
sandy081
approved these changes
Jun 10, 2022
src/vs/workbench/services/sessionSync/browser/sessionSyncWorkbenchService.ts
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #141293
Adds:
Demo using test server:
Next steps: