Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Sync: Ignore a setting locally #89627

Closed
weinand opened this issue Jan 29, 2020 · 10 comments
Closed

Settings Sync: Ignore a setting locally #89627

weinand opened this issue Jan 29, 2020 · 10 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-sync under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jan 29, 2020

Refs: #89358

I tried to ignore the setting "editor.fontFamily" from being synced on linux (because I had issues with installing the nice coding fonts there).

So I added "editor.fontFamily" to the "sync.ignoredSettings" setting on linux.

But because "sync.ignoredSettings" is synced too, the setting now is ignored everywhere (which I didn't intend).

@sandy081 suggested to add "sync.ignoredSettings" to itself which seems to work..

But this approach appeared to be a kludge and it is very difficult to understand what is going on now. In order to understand whether a specific setting is synced, you have to check whether it is mentioned in the "sync.ignoredSettings" setting and then you have to check whether "sync.ignoredSettings" refers to itself...

What I would really like to have is a simple and direct way to exclude settings from syncing. E.g. adding a '!' as the first character of a settings name excludes it from syncing. Or nesting settings within a section named "!" or "nosync" excludes them all from syncing.

The "sync.ignoredSettings" approach is a bit ugly because it relies on another setting, which is again prone to another level of syncing complexity.

@sandy081 sandy081 added feature-request Request for new features or functionality settings-sync labels Jan 29, 2020
@sandy081 sandy081 added this to the February 2020 milestone Jan 29, 2020
@sandy081 sandy081 added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 6, 2020
@sandy081 sandy081 mentioned this issue Feb 6, 2020
6 tasks
@sandy081 sandy081 removed the feature-request Request for new features or functionality label Feb 12, 2020
@sandy081
Copy link
Member

But because "sync.ignoredSettings" is synced too, the setting now is ignored everywhere everywhere (which I didn't intend).

Is it that you want to ignore this setting on this machine or you want this to be synced only in linux platforms. This looks to me a scenario for platform specific settings.

@weinand
Copy link
Contributor Author

weinand commented Feb 12, 2020

Yes, in this specific case I could have used a linux specific setting.
But in general excluding settings from sync by using another setting that needs to be excluded from sync remains tricky...

@sandy081
Copy link
Member

But in general excluding settings from sync by using another setting that needs to be excluded from sync remains tricky...

Agreed. But this setting is synced by default because If a user ignore a setting then it is expected to be ignored everywhere.

I do not see a use case of ignoring a setting only on local machine.

@weinand
Copy link
Contributor Author

weinand commented Feb 14, 2020

use case: for security reasons I do not want to leak a single setting to anywhere.

@sandy081
Copy link
Member

Do you mean value of the setting or the setting id?

@sandy081 sandy081 modified the milestones: February 2020, Backlog Feb 25, 2020
@sandy081
Copy link
Member

sandy081 commented Feb 25, 2020

Made current ignored setting to be always synced and cannot be ignored.

Moving this to backlog and will get back to this if we get a use case to have ignored setting which should not be synced.

@jsejcksn
Copy link

jsejcksn commented Aug 22, 2020

I have the same issue: I use the Fira Code typeface, specifically the Retina weight variation. It uses a different name for macOS vs Linux/Windows, so without having platform-specific setting support, this breaks for me either on the other platforms.

I think my issue is related, but not the same as the author's. I searched the open issues and this one was the closest, especially after reading this comment, but if you think I should post to a different issue, please advise.

@sandy081
Copy link
Member

@jsejcksn your request is related to #5595

@jsejcksn
Copy link

your request is related to #5595

Thanks, yes a duplicate of this comment

@sandy081 sandy081 added the *out-of-scope Posted issue is not in scope of VS Code label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-sync under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants
@jsejcksn @weinand @sandy081 and others