Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: LFS support for image diffing #86611

Closed
mjbvz opened this issue Dec 9, 2019 · 2 comments
Closed

Git: LFS support for image diffing #86611

mjbvz opened this issue Dec 9, 2019 · 2 comments
Assignees
@lszomoru
Labels
feature-request Request for new features or functionality git GIT issues
Milestone
December / Januar...

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 9, 2019 •
edited
Loading

Steps to Reproduce:

  1. In a repository with git LFS enabled (such as the VS Code docs repo)
  2. Open a modified image diff

Bug
Left hand side shows an image load error. Here's the content for a git lfs file we get:

version https://git-lfs.github.com/spec/v1
oid sha256:65ccfe99efef1afc4bbd0fade1397c620759d165d0af1f2394afce4f34570a5f
size 166430

This works properly when not using git LFS

Does this issue occur when all extensions are disabled?: Yes
@mjbvz mjbvz changed the title GitFS does not handle LFS image diff GitFS does not handle LFS resources Dec 9, 2019
@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Dec 10, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Dec 10, 2019
@joaomoreno joaomoreno changed the title GitFS does not handle LFS resources Git: LFS support for image diffing Dec 10, 2019
@mjbvz mjbvz mentioned this issue Feb 29, 2020
Closed
@lszomoru lszomoru self-assigned this May 6, 2020
@joaomoreno joaomoreno removed their assignment Nov 11, 2020
@mjbvz mjbvz mentioned this issue Mar 29, 2021
Closed
@5c077yP
Copy link

5c077yP commented Jul 7, 2021

Wow just found this comment on another repos' issues page: git-lfs/git-lfs#440 (comment). tl;dr: git config diff.lfs.textconv cat . Now both sides work for me

@ianthomas23 ianthomas23 mentioned this issue Oct 20, 2023
Closed
2 tasks
@lszomoru
Copy link
Member

Closing based on this comment - #86611 (comment).

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
5 participants
@joaomoreno @5c077yP @lszomoru @mjbvz @aiday-mar