Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some command names not showing in keyboard shortcuts editor #79404

Closed
jabacchetta opened this issue Aug 18, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded
Milestone

Comments

@jabacchetta
Copy link

jabacchetta commented Aug 18, 2019

Explanation:

From my understanding, when in the Keyboard Shortcuts UI editor:

  • the command column defaults to showing the command name (when one is available for the command id)
  • command IDs are differentiated by a lighter font weight in the commands column
  • command names indicate that a command ID can be executed in the command palette

There isn't any documentation on this, however, so maybe I'm wrong. Assuming I'm right, though, it looks like some command names are not showing as they should.

Steps to Reproduce:

  1. Open command palette and search for the View: Close Editor command, noting that it exists.
  2. Open the keyboard shortcuts UI editor and search for View: Close Editor. Note that the command name does not appear.
  3. Clear the search input and search for workbench.action.closeActiveEditor. Note that the command ID appears, and it is the command ID that is executed by the View: Close Editor command name. To prove this, change the keybinding for this command ID and then search for the View: Close Editor command name in the palette once more, noting that the keybinding shown to the right of that command name in the palette is now changed as well.

More Information:

I've run into a similar situation with the Insert Snippet command, which seems to indicate that there's more going on with command names than I'm aware of. But again, I haven't been able to find any additional information on this.

Environment:

  • VSCode Version: 1.37.1
  • OS Version: macOS Mojave 10.14.4
  • Does this issue occur when all extensions are disabled? Yes
@vscodebot
Copy link

vscodebot bot commented Aug 18, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot removed the new release label Aug 20, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues labels Aug 26, 2019
@sandy081 sandy081 added this to the August 2019 milestone Aug 26, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 28, 2019
@jabacchetta
Copy link
Author

jabacchetta commented Aug 30, 2019

@sandy081 @RMacfarlane

Similar:

  1. Same appears to be happening for editor.action.showSnippets, which is the command executed by the Insert Snippet command. Insert Snippet command name is not showing up above the command ID. This command name should maybe be renamed to Show Snippets as well? Because there's also a separate insertSnippet command ID.

  2. editor.action.insertSnippet command ID is not showing in the search. Looks like there are actually three different commands being named/mixed up?

@sandy081
Copy link
Member

sandy081 commented Sep 2, 2019

Good catch @jabacchetta. Filed a separate issue #80197 to track it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants