-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sortText of ItemCompletion are being ignored when comparing to ItemCompletion that doesn't specify the sortText field #66109
Comments
Hm, today we only compare |
@jrieken Does that mean, that the documentation is currently outdated?
https://code.visualstudio.com/api/references/vscode-api#CompletionItem.sortText |
Another way this can surface is if you have multiple extensions contributing to the same completion list, with one using IntelliCode uses @jrieken did you end up trying what you mentioned above? |
No, but we should. I will push a change today and then we (that includes your and IntelliCode) need to observe how https://code.visualstudio.com/insiders/ behaves. |
@mjbvz Just a heads up that this changed - I believe the original (questionable) behaviour was introduced for TS, or TS as it was years back, and I wonder if you have observed any difference since the last week? |
@jrieken Sorry for the delay, I just had a chance to try this and it looks good to me. |
Yeah, we haven't seen issues (yet) and I am all in for shipping like this in September. |
Issue Type: Bug
Create a new Typescript extension with
yo code
.In package.json, replace the
actionEvents
field withReplace extension.ts with the following code:
Run the extension and create a new txt file.
Press ctrl+space to show completion options.
What I expected:
The
'C'
option will be sorted to be shown above the'B'
option, because it has asortText
of'A'
.What actually happened:
The
'C'
option will be sorted to be shown below the'B'
option, because itssortText
is being ignored and thelabel
is used for sorting instead.You can see that if you just add a sortText of 'B' to 'B' it works as expected.
VS Code version: Code - Insiders 1.31.0-insider (bae6c84, 2019-01-04T06:17:20.719Z)
OS version: Windows_NT x64 10.0.17134
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: