Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: introduce border colors for individual components to override contrastBorder #26530

Closed
pahen opened this issue May 12, 2017 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone

Comments

@pahen
Copy link

pahen commented May 12, 2017

I wanna add a border to the right side of the sidebar. The only way to do it now that I know of is to use contrastBorder but that's adding a lot of other borders too which I don't want. Is it possible to do it in another way? And can you add support for it if it's not possible? Needed for ayu-theme/vscode-ayu#7

@bpasero
Copy link
Member

bpasero commented May 12, 2017

There are still many borders that are not configurable on their own but coming in via contrastBorder. More examples include: status bar border, activity bar border, tabs container border.

image

@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues labels May 12, 2017
@bpasero bpasero changed the title Theming: add sidebar border without using contrastBorder Theming: introduce border colors for individual components to override contrastBorder May 12, 2017
@bpasero bpasero self-assigned this May 22, 2017
@bpasero bpasero added this to the May 2017 milestone May 22, 2017
@bpasero
Copy link
Member

bpasero commented May 22, 2017

I added specific border colors to override contrastBorder:

  • editorGroupHeader.tabsBorder
  • statusBar.border
  • activityBar.border
  • sideBar.border

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

2 participants