Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things missing in the theme without styling supports in the theming API #9

Closed
2 of 4 tasks
teabyii opened this issue May 18, 2017 · 7 comments
Closed
2 of 4 tasks

Comments

@teabyii
Copy link
Collaborator

teabyii commented May 18, 2017

@teabyii
Copy link
Collaborator Author

teabyii commented May 18, 2017

@pahen

Thank you for your PR ! 🎉🎉🎉

We track the things which maybe can be fixed with theme API supports in the future here.

@pahen
Copy link
Collaborator

pahen commented May 19, 2017

Perfect! 🕺

@pahen
Copy link
Collaborator

pahen commented May 24, 2017

The "Text selection color" should work already. Can you provide a screenshot where it doesn't work @ajitid? And what version of VSCode are you running?

@pahen
Copy link
Collaborator

pahen commented May 24, 2017

Correct. It was added after 1.12.2 was released. Should work in insiders build.

@pahen
Copy link
Collaborator

pahen commented May 24, 2017

The same is valid for "Allow theming of parameter hints". Should work in insiders build.

@ajitid
Copy link

ajitid commented May 24, 2017

Okay, removed all of my comments. Thanks!

@pahen
Copy link
Collaborator

pahen commented May 25, 2017

I moved out the relevant stuff into own issues so I think we can close this now @teabyii

@pahen pahen closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants