Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot distinguish editor in output pane from the other editors #2368

Closed
egamma opened this issue Jan 26, 2016 · 8 comments
Closed

Cannot distinguish editor in output pane from the other editors #2368

egamma opened this issue Jan 26, 2016 · 8 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jan 26, 2016

Testing #2145

Select text in the output window.

NVDA reports the current focus (NVDA+Tab) as

Editor content edit focused multi line

You cannot distingush the output pane from a content editor.

@egamma egamma added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 26, 2016
@bpasero bpasero modified the milestone: Jan 2016 Jan 26, 2016
@bpasero bpasero assigned alexdima and unassigned bpasero Jan 26, 2016
@bpasero
Copy link
Member

bpasero commented Jan 26, 2016

@alexandrudima I guess we need some kind of editor option to pass in so that I can control this?

@alexdima
Copy link
Member

👍 I'll add an editor option

@alexdima
Copy link
Member

@bpasero Just added an option: "ariaLabel". Can you please adopt it in the workbench editors?

Here is the message I get in Visual Studio:
image

I would not go with such a long message. Maybe [editor name|file name] + 'text editor'?

@alexdima alexdima assigned bpasero and unassigned alexdima Jan 28, 2016
@bpasero
Copy link
Member

bpasero commented Jan 28, 2016

I am not sure we should announce the file name as part of the editor, we should clarify this is what others do (why is VS not?) and then we can add it. For now I added the following labels:

  • readonly editor (e.g. a file on the index): Readonly text editor
  • writeable editor for untitled file: Untitled file text editor
  • readonly diff editor: Readonly text diff editor
  • writeable diff editor: Text diff editor
  • writeable file: Text file editor
  • output panel: Output panel

@alexdima
Copy link
Member

@bpasero The reason would be because in VS you can actually tab to the "tab name" which reads you the file name. For us, you have no clue what file name you are trying to edit.

verifier: please check if you can hear the file name you are tabbing into for editing in any way

@bpasero
Copy link
Member

bpasero commented Jan 29, 2016

Makes sense, we can do this for Feb 2016, currently the file name will not be read at all.

@bpasero
Copy link
Member

bpasero commented Jan 29, 2016

#2526

@egamma egamma added the verified Verification succeeded label Jan 29, 2016
@alexdima
Copy link
Member

👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants