Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: TextModel got disposed before DiffEditorWidget model got reset #218001

Closed
benibenj opened this issue Jun 25, 2024 · 2 comments · Fixed by #222197
Closed

Error: TextModel got disposed before DiffEditorWidget model got reset #218001

benibenj opened this issue Jun 25, 2024 · 2 comments · Fixed by #222197
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@benibenj
Copy link
Contributor

I'm not able to find repro steps, but I saw multiple of these errors in the console. I was opening multi diff editors from the commit graph and changing branches.

ERR TextModel got disposed before DiffEditorWidget model got reset: Error: TextModel got disposed before DiffEditorWidget model got reset
    at d.value (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:785:84605)
    at l.B (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:93:732)
    at l.C (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:93:802)
    at l.fire (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:93:1018)
    at U.dispose (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:750:5574)
    at f.destroyModel (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:764:1073)
    at P.dispose (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1682:13775)
    at P.dispose (vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2207:19528)
    at vscode-file://vscode-app/c:/Users/besimmonds/AppData/Local/Programs/Microsoft%20VS%20Code%20Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2207:25083
@hediet
Copy link
Member

hediet commented Jun 25, 2024

Without an unminified stack trace, this issue is unactionable unfortunately.

@hediet hediet closed this as completed Jun 25, 2024
@hediet hediet reopened this Jul 9, 2024
@hediet hediet added this to the July 2024 milestone Jul 9, 2024
@aiday-mar
Copy link
Contributor

Error received around 200 times on Insiders 1.92. Corresponding issue in telemetry will be marked as triaged.

hediet added a commit that referenced this issue Jul 19, 2024
@hediet hediet closed this as completed in 0dae07c Jul 19, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 19, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants