Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Terminal hyperlinks configurable #21616

Closed
joaomoreno opened this issue Mar 1, 2017 · 2 comments
Closed

Make Terminal hyperlinks configurable #21616

joaomoreno opened this issue Mar 1, 2017 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 1, 2017

I find it very annoying that Terminal hyperlinks just work on hover & click. Many times I click a terminal because I want to focus it; now with hyperlinks I often find myself navigating somewhere I didn't want to because I happened to hit a hyperlink inside the terminal.

I'd expect links to only work as I hold Ctrl or Cmd, just like iTerm and our editor work.

Since this may be a user preference, I suggest to create a setting for it. I also propose to have the default behaviour be the same as the editor: hyperlinks only show and work when holding the keyboard key.

@Tyriar
Copy link
Member

Tyriar commented Mar 1, 2017

I'm actually planning on making ctrl+click the default for the reasons you mention #21506

@Tyriar Tyriar closed this as completed Mar 1, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 1, 2017
@joaomoreno
Copy link
Member Author

Sorry for not searching beforehand 🐙

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants