Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require cmd/ctrl+click to follow links in the terminal #21506

Closed
Tyriar opened this issue Feb 27, 2017 · 2 comments
Closed

Require cmd/ctrl+click to follow links in the terminal #21506

Tyriar opened this issue Feb 27, 2017 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
March 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2017 •
edited
Loading

Issues with current non-ctrl system:

  • Not aligned with editor (related Align rendering of links #21347)
  • Users can accidentally open links when they want to focus the terminal or select text
  • It could mess with terminal applications
  • This is how most terminal emulators work
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 27, 2017
@Tyriar Tyriar added this to the March 2017 milestone Feb 27, 2017
@Tyriar Tyriar self-assigned this Feb 27, 2017
This was referenced Feb 27, 2017
Closed
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Mar 2, 2017

Upstream issue: xtermjs/xterm.js#578

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 2, 2017
@Tyriar Tyriar changed the title Require ctrl+click to follow links in the terminal Require cmd/ctrl+click to follow links in the terminal Mar 3, 2017
@kieferrm kieferrm mentioned this issue Mar 3, 2017
Closed
58 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Mar 7, 2017

Follow up #21934

@Tyriar Tyriar closed this as completed Mar 7, 2017
@Tyriar Tyriar mentioned this issue Mar 24, 2017
Closed
3 tasks
@Tyriar Tyriar added on-testplan feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Mar 24, 2017
@julianlam julianlam mentioned this issue Aug 1, 2017
Open
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
1 participant
@Tyriar