Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vscode-selfhost-test-provider into VS Code workspace #207756

Closed
sandy081 opened this issue Mar 14, 2024 · 1 comment · Fixed by #208699
Closed

Move vscode-selfhost-test-provider into VS Code workspace #207756

sandy081 opened this issue Mar 14, 2024 · 1 comment · Fixed by #208699
Assignees
@connor4312
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
April 2024

Comments

@sandy081
Copy link
Member

sandy081 commented Mar 14, 2024 •
edited
Loading

With the introduction of workspace extensions, we can now move vscode-selfhost-test-provider extension into VS Code repository under .vscode/extensions folder.

  • Move the extension to .vscode/extensions folder.
  • Use tsconfig.json similar to the one in builtin extensions - example
  • Add '.vscode/extensions/vscode-selfhost-test-provider' to dirs in dirs.js file
  • Add '.vscode/extensions/vscode-selfhost-test-provider/tsconfig.json' to compilations in gulpfile.extensions.js file
  • Remove redundant files and update code to work in this environment.
  • Remove "ms-vscode.vscode-selfhost-test-provider" entry in extensions.json file

To check

  • Run Build Task - cmd+shift+b - make sure extension sources are built
  • Uninstall the vscode-selfhost-test-provider extension - Reload window.
  • Open workspace recommendations - Extensions View - @recommended and install vscode-selfhost-test-provider workspace extension
  • Make sure the extension is running
@sandy081 sandy081 added this to the March 2024 milestone Mar 15, 2024
@connor4312 connor4312 added the debt Code quality issues label Mar 18, 2024
connor4312 added a commit that referenced this issue Mar 25, 2024
@connor4312
eng: move selfhost test provider as a workspace extension
541ce72 
Testing #208184, closes #207756
@connor4312 connor4312 mentioned this issue Mar 25, 2024
Merged
@connor4312
Copy link
Member

PR is staged but there's no rush so I'll merge in debt week

@connor4312 connor4312 modified the milestones: March 2024, April 2024 Mar 26, 2024
connor4312 added a commit that referenced this issue Mar 28, 2024
@connor4312
eng: move selfhost test provider as a workspace extension (#208699)
d42fad2 
Testing #208184, closes #207756
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Mar 28, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

eng: move selfhost test provider as a workspace extension microsoft/vscode
3 participants
@connor4312 @sandy081 @vscodenpa