Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to fullscreen video in webview #194433

Closed
zhouxinghong opened this issue Sep 28, 2023 · 11 comments
Closed

Unable to fullscreen video in webview #194433

zhouxinghong opened this issue Sep 28, 2023 · 11 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@zhouxinghong
Copy link

zhouxinghong commented Sep 28, 2023

Hello! Now VSCode has been upgraded to Electronic 25.8.1. Please allow video playback to be maximized (full screen) and have sound playback effects.

If the video playback cannot be maximized (full screen) and has sound playback effect. Then this function will be a crippled existence. Hope you can continue to improve it.

image

Windows 10
1.82.2

@deepak1556
Copy link
Collaborator

Seems related to #187525

@zhouxinghong can you clarify how update to v25.8.1 helps addressing this bug ?

@zhouxinghong
Copy link
Author

I don't understand how node runs, but I believe you can solve this problem well.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Dec 6, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 6, 2023

Seems like #187525

@zhouxinghong Does the video play when not in full screen mode?

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Dec 6, 2023
@zhouxinghong
Copy link
Author

@mjbvz
Hello! Thank you for supporting this feature!
In non-full-screen mode, .mp4 videos can be played (however, other types of videos have not been tested to see whether they can be played successfully), and there is no sound when playing .mp4 videos. . .

@deepak1556
Copy link
Collaborator

@zhouxinghong the list of codecs and containers supported are listed in #180780, if the mp4 video has audio encoded to a format not in the list then audio decoding will fail. Closing as expected.

@zhouxinghong
Copy link
Author

@deepak1556
Even if you don't support sound, you should support full screen player! It is a very irresponsible work attitude to close the matter without solving the problem. . .

@zhouxinghong
Copy link
Author

zhouxinghong commented Dec 7, 2023

@deepak1556 This issue is already being addressed by @mjbvz. . . Please don't close the work assigned to @mjbvz easily, okay?

@deepak1556
Copy link
Collaborator

Sorry, I see the issue combines both audio playback and fullscreen support. Please open separate issues to avoid confusion in the future. Reopening to triage the fullscreen support. Can you provide a minimal test case to help us repro the issue.

@deepak1556 deepak1556 reopened this Dec 7, 2023
@deepak1556 deepak1556 changed the title Hello! Now VSCode has been upgraded to Electronic 25.8.1. Please allow video playback to be maximized (full screen) and have sound playback effects. Unable to fullscreen video in webview Dec 7, 2023
@zhouxinghong
Copy link
Author

Sorry, I see the issue combines both audio playback and fullscreen support. Please open separate issues to avoid confusion in the future. Reopening to triage the fullscreen support. Can you provide a minimal test case to help us repro the issue.

Sample video so you can reproduce the issue:

  1. Open the video file in VSCode;
  2. Open the video file in a Markdown file;
2023-03-25-08h09m51s-NHK.WORLD-.mp4

@vscodenpa
Copy link

Hey @mjbvz, this issue might need further attention.

@zhouxinghong, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants