Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: ffmpeg codec support has not changed #180780

Closed
2 tasks done
deepak1556 opened this issue Apr 25, 2023 · 2 comments
Closed
2 tasks done

Test: ffmpeg codec support has not changed #180780

deepak1556 opened this issue Apr 25, 2023 · 2 comments

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Apr 25, 2023

Refs: https://github.com/microsoft/vscode-electron-prebuilt/pull/22

Complexity: 3

Authors: @deepak1556

Create Issue


Summary:

We have now changed how ffmpeg component is packaged in the MS Electron repo. This should not cause any change in our supported list of codecs and containers and the test plan item is to verify it. The following are the list of codecs and containers we should be supporting,

  • Vorbis
  • Flac
  • VP8
  • MP3
  • WAV
  • OGG
  • H.264
  • MP4 (without AAC support)

Steps to Test:

  • F1 > Help: List Audio Cues > you can hear all the audio cues being played
  • You can play audio files from notebooks. Code sample:
import IPython.display as ipd
ipd.audio('PATH_TO_SOME_AUDIO_FILE')

Audio file samples for testing:
Unsupported_audio.zip - Contains opus and aac
Supported_audio.zip - Contains mp3 and ogg

  • Convert them to other formats not in the supported codec list and ensure that they don't play (Optional, good to test)
  • Verify video files in release notes play as expected
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 25, 2023
@ghost ghost assigned gregvanl and bpasero Apr 25, 2023
@bpasero bpasero removed their assignment Apr 25, 2023
@bpasero
Copy link
Member

bpasero commented Apr 25, 2023

I tested macOS (Intel).

@gregvanl
Copy link

I tested Windows 11

@gregvanl gregvanl removed their assignment Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants