Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering VS code processes when restarting to update #17565

Closed
QwertyZW opened this issue Dec 19, 2016 · 17 comments
Closed

Lingering VS code processes when restarting to update #17565

QwertyZW opened this issue Dec 19, 2016 · 17 comments
Assignees
Labels
info-needed Issue requires more information from poster windows VS Code on Windows issues
Milestone

Comments

@QwertyZW
Copy link
Contributor

QwertyZW commented Dec 19, 2016

  • VSCode Version: 1.8.0
  • OS Version: Windows 10 Pro, Version 1607, OS Build: 14393.576

Encountered this when updating to version 1.8.1

Lingering VS code processes in the background block it from updating itself

toomany3
toomany2
toomany

The processes you see here are besides the Setup process that was somewhere up the list

I had to manually kill the 6 processes you see here before I was able to update.

@egamma egamma added the install-update VS Code installation and upgrade system issues label Dec 20, 2016
@joaomoreno
Copy link
Member

Any chance you can find out the full command line which spawned those processes?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jan 3, 2017
@QwertyZW
Copy link
Contributor Author

QwertyZW commented Jan 4, 2017

Does VS Code/Setup/Update keep a log anywhere by default? I'm not familiar with windows 10's system log mechanisms/if it had any

@joaomoreno
Copy link
Member

No, but if you see them again, you can use Process Hacker to figure out each process' full command line.

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Feb 2, 2017

ab
1
2
3
4
5
6
7
8

@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno assigned mjbvz, dbaeumer and aeschli and unassigned joaomoreno Feb 2, 2017
@joaomoreno
Copy link
Member

@mjbvz for TypeScript
@dbaeumer @aeschli for html/languageclient

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed install-update VS Code installation and upgrade system issues info-needed Issue requires more information from poster labels Feb 2, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Feb 2, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Feb 3, 2017

I think the root cause of this is the extension host not shutting down. All other processes are started from the extension host and shutdown if they are asked to do so, the stream closes they use to listen on or when the process that started them disappears.

@dbaeumer
Copy link
Member

dbaeumer commented Feb 3, 2017

Adding @alexandrudima. The extension host under Windows is started in detach mode to support a proper shutdown sequence. However looking at the code I can only think about one case where the extension host wouldn't shutdown: if it is busy and can't process events. @QwertyZW in your case is the --extensionHost process consuming lots of CPU cycles?

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Feb 3, 2017

@dbaeumer Nope. All of them looked pretty idle to me. The only one that showed any activity was the 4th one from the top and even then it was only periodic/very occasional spikes going no higher than 5%

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Feb 3, 2017

The processes still linger in the background after aborting. Once I manually kill those processes I'm unable to recreate the situation again. Updating works fine afterwards.

However if I keep them running, start a new window and try to update I run into the same problem.

It might be an issue related to suspending the processes (when putting comp to sleep) but I'm not sure. The system is always running/sleeping unless I shut it down for updates

@dbaeumer
Copy link
Member

dbaeumer commented Feb 6, 2017

@QwertyZW when you see it again will killing the process that has --extensionHost on the command line make all the other processes go away in a reasonable amount of time?

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Feb 6, 2017

Will it make all the other processes go away? in 1.9 --extensionHost seems to be one of the main process' grandchildren.

@dbaeumer
Copy link
Member

dbaeumer commented Feb 6, 2017

Yes, it should make all the other processes go away

@aeschli aeschli removed their assignment Feb 21, 2017
@mjbvz mjbvz added the info-needed Issue requires more information from poster label Mar 21, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 21, 2017

@QwertyZW Can you please try upgrading to VSCode 1.10+ to pick up TS 2.2.1. Let me know if you still see the typescriptserver process hanging around. If you do, try collecting the TSS_LOGs as documented here: #21442 (comment)

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Apr 1, 2017

Upgraded to 1.10 a while back without a problem @mjbvz

@alexdima alexdima added the windows VS Code on Windows issues label May 21, 2017
@QwertyZW
Copy link
Contributor Author

QwertyZW commented Jun 1, 2017

Upgraded again several times from 1.10 through to 1.12.2.

I think this ticket can be closed now. Please feel free do to so if this ticket is not relevant anymore.

@alexdima
Copy link
Member

alexdima commented Jun 1, 2017

Thank you @QwertyZW

I'll close this issue for now. We know we have a problem that sometimes the extension host process lingers around. We will try to tackle it with #26445

@alexdima alexdima closed this as completed Jun 1, 2017
@alexdima alexdima modified the milestones: May 2017, Backlog Jun 1, 2017
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

8 participants