Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling a notebook can be jarring and disorienting #147527

Closed
greazer opened this issue Apr 15, 2022 · 5 comments · Fixed by #149195 or #151807
Closed

Scrolling a notebook can be jarring and disorienting #147527

greazer opened this issue Apr 15, 2022 · 5 comments · Fixed by #149195 or #151807
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-workflow Issues that interrupt expected or desirable behavior verified Verification succeeded
Milestone

Comments

@greazer
Copy link
Member

greazer commented Apr 15, 2022

Scrolling through cells with the keyboard exhibits jarring behavior. I frequently find myself not sure what happened as I'm scrolling. When you scroll off the bottom or over the top of the cell, the caret should remain in a very similar place to where it was just at.

An animated gif is needed here.
Recording 2022-04-15 at 13 15 20

Whereas Google Colab (and probably Jupyter) does this:
Recording 2022-04-15 at 13 17 53

@roblourens roblourens self-assigned this May 10, 2022
@roblourens roblourens added this to the May 2022 milestone May 10, 2022
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior labels May 10, 2022
@lramos15 lramos15 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Jun 2, 2022
@lramos15
Copy link
Member

lramos15 commented Jun 2, 2022

Scrolling down via keyboard feels smooth.

Scrolling up my carat sometimes gets lost and still has a bit of jumpy feel. Let me know if you want a gif or if this is just expected

@lramos15 lramos15 reopened this Jun 2, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jun 2, 2022
@rebornix rebornix removed their assignment Jun 2, 2022
@roblourens
Copy link
Member

All I changed here was where the code cell is revealed when moving the cursor from one code cell editor to another. It should reveal the cell at the top or bottom of the viewport to try to keep the cursor close to the same place on the screen. There are other issues that might contribute to "jumpiness", can you give more details?

@lramos15
Copy link
Member

lramos15 commented Jun 2, 2022

Here's a gif where all I do is press and .
Recording 2022-06-02 at 13 55 44

Two problems you can see

  1. Even with the cursors at the start of the line when pressing down it doesn't always enter the cell at the start of the line. This can be seen at the very start of the gif
  2. When scrolling up towards the end of the gif it appears to just skip some cells and jump as the cursor moves over them rather than enters the cell

Let me know if there's more info I can provide

@roblourens
Copy link
Member

Ok yeah,

  1. Seems like sometimes when moving from a markdown to code cell in this mode, the cursor goes to the first line but not the first column
  2. When hitting a markdown cell, that cell is still revealed in the middle
  3. Also noticed that we don't always reveal a line in a code cell editor if it's partially within the viewport

image

@roblourens
Copy link
Member

Yeah, I want to do this differently for moving from and to markdown cells in this mode. I'd forgot that uses a different command than with code cells. Will fix it up in debt week.

@roblourens roblourens modified the milestones: May 2022, June 2022 Jun 3, 2022
@roblourens roblourens added the debt Code quality issues label Jun 3, 2022
roblourens added a commit that referenced this issue Jun 11, 2022
roblourens added a commit that referenced this issue Jun 13, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 13, 2022
@roblourens roblourens removed verification-found Issue verification failed debt Code quality issues labels Jun 29, 2022
@rebornix rebornix added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-workflow Issues that interrupt expected or desirable behavior verified Verification succeeded
Projects
None yet
6 participants
@roblourens @rebornix @lramos15 @greazer @vscodenpa and others