Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Open file or Open folder creates dialog behind active window #146422

Closed
kathenas opened this issue Mar 31, 2022 · 39 comments · Fixed by #213050
Closed

[Linux] Open file or Open folder creates dialog behind active window #146422

kathenas opened this issue Mar 31, 2022 · 39 comments · Fixed by #213050
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member dialogs Issues with native and custom dialogs electron Issues and items related to Electron electron-17-update Issues related to electron 17 update linux Issues with VS Code on Linux native-file-dialog Issues with native file dialog on-testplan upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@kathenas
Copy link

Native dialogs Open file or Open folder opening behind main window on RHEL 8/EL 8 clones.

This has only happened after updating to 1.66.0.

Desktop Environment: gnome.

Screencast.from.31-03-22.12.32.59.mp4
@kathenas kathenas changed the title Native diloags Open file or Open folder opening behind main window on RHEL 8/El8 clones Native dialogs Open file or Open folder opening behind main window on RHEL 8/El8 clones Mar 31, 2022
@sbatten sbatten assigned deepak1556 and unassigned sbatten Mar 31, 2022
@deepak1556 deepak1556 added linux Issues with VS Code on Linux electron-17-update Issues related to electron 17 update dialogs Issues with native and custom dialogs confirmation-pending labels Mar 31, 2022
@EvgeniyMakhmudov
Copy link

The same problem on Linux Mint with Mate env after update to 1.66. I hope that will be fixed in 1.66.1 but it is not.

@jherico
Copy link

jherico commented Apr 14, 2022

Same behavior on Ubuntu 22.04 pre-release, but I was also seeing it on 20.04 before I upgraded yesterday.

Visual Studio Code

"Open File" is ready

and then I can get to the dialog by clicking on the toast or by using the switch-window shortcut key.

Code About dialog output

Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:49:24.808Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.15.0-25-generic

@bradym
Copy link

bradym commented Apr 15, 2022

Seeing the same issue, I didn't find this ticket so I filed #147400 which I have now closed as a duplicate of this one. Mentioning here in case there's anything useful on that ticket when this one gets worked on.

@carneeki
Copy link

Also happening to me on Arch Linux with GNOME 42 under Wayland:

Help -> About as follows:

Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:49:24.808Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.17.3-arch1-1

@gregersn
Copy link

Same issue, Ubuntu 21.10, Cinnamon VM.

Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:49:24.808Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.13.0-39-generic

@ghost
Copy link

ghost commented Apr 27, 2022

Same issue on Arch Linux running VSCodium on Cinnamon.

Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-13T00:16:29.523Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.17.4-zen1-1-zen

@kozhukalov
Copy link

Same for me

Version: 1.66.2
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:49:24.808Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.17.4-100.fc34.x86_64

@KollegeX
Copy link

Here as well

Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-04-02T14:00:30.308Z
Electron: 17.3.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.15.32-1-MANJARO

@embeddedt
Copy link

Same issue using Arch and KDE Plasma.

Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-04-02T14:00:30.308Z
Electron: 17.4.0
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.17.4-arch1-1

Operating System: Arch Linux
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3
Kernel Version: 5.17.4-arch1-1 (64-bit)
Graphics Platform: X11

@astrolemonade
Copy link
Contributor

Same issue here using Solus Linux 4.1

Version: 1.67.0
Commit: 57fd6d0195bb9b9d1b49f6da5db789060795de47
Date: 2022-05-06T09:53:29+10:00
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.15.37-214.current

@wc7086
Copy link

wc7086 commented May 15, 2022

Same issue using Arch and KDE Plasma(Wayland).
But, this error does not appear when opening it for the first time. (Delete all configuration files or reboot the system and open vscode for the first time)
@deepak1556

Version: 1.67.1
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-10T21:35:59.370Z
Electron: 17.4.3
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.17.7-arch1-1

@AlbanMinassian
Copy link

Same problem ubuntu 20 or 22:

code (v1.67.1)
first open dialog: right place
second et other open dialog: always behind application

sudo apt ugrade (code 1.67.1 to 1.67.2)
code
first open dialog: right place
second et other open dialog: always behind application

@SethBashamDev
Copy link

Currently have this issue with Save As. Running Fedora 36 Workstation.

VS Code installed via Microsoft repo not Snap/FlatPak

@eksperimental
Copy link

Currently have this issue with Save As. Running Fedora 36 Workstation.

VS Code installed via Microsoft repo not Snap/FlatPak

Seems like a temporary solution

@toasterofbread
Copy link

Currently have this issue with Save As. Running Fedora 36 Workstation.
VS Code installed via Microsoft repo not Snap/FlatPak

Seems like a temporary solution

I think they were just mentioning the setup they experienced the issue with, not suggesting it as a solution.

@eksperimental
Copy link

Currently have this issue with Save As. Running Fedora 36 Workstation.
VS Code installed via Microsoft repo not Snap/FlatPak

Seems like a temporary solution

I think they were just mentioning the setup they experienced the issue with, not suggesting it as a solution.

That's why I say "temporary".

@toasterofbread
Copy link

That's why I say "temporary".

I mean that it's not a solution at all, just that they experienced the bug using the MS repo version.

@eksperimental
Copy link

That's why I say "temporary".

I mean that it's not a solution at all, just that they experienced the bug using the MS repo version.

It is a temporary solution for those who need to use the editor today.

@kathenas
Copy link
Author

That's why I say "temporary".

I mean that it's not a solution at all, just that they experienced the bug using the MS repo version.

It is a temporary solution for those who need to use the editor today.

@SethBashamDev is stating they have the issue and that the version they are using is installed from the MS RPM repo. There is no mention of a temporary solution. Please refrain from adding noise to this bug report.

@kathenas
Copy link
Author

kathenas commented Jul 6, 2022 via email

@ecm75
Copy link

ecm75 commented Jul 7, 2022

This above mentioned workaround works for me on Debian 11 not using Wayland:
GTK_USE_PORTAL=0 code

Version: 1.68.1
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-15T02:58:26.441Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.10.0-14-amd64

@bpasero bpasero pinned this issue Jul 7, 2022
@deepak1556 deepak1556 changed the title Native dialogs Open file or Open folder opening behind main window on RHEL 8/EL8 clones - Regresssion [Linux] Open file or Open folder creates dialog behind active window Jul 7, 2022
@weinand weinand unpinned this issue Jul 8, 2022
@ogrand
Copy link

ogrand commented Jul 13, 2022

Same issue with latest code release (open dialog is behind vscode window).

Version: 1.69.1
Commit: b06ae3b
Date: 2022-07-12T08:28:29.328Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Linux x64 5.4.0-122-generic

Workaround GTK_USE_PORTAL=0 code doesn't fix.

Regards

@phamphu232
Copy link

Same issue

Version: 1.69.1
Commit: b06ae3b
Date: 2022-07-12T08:28:29.328Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Linux x64 5.4.0-121-generic

@Rayv1
Copy link

Rayv1 commented Jul 13, 2022

same

Version: 1.69.1
Commit: b06ae3b
Date: 2022-07-12T08:28:29.328Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Linux x64 5.13.0-52-generic snap

@deepak1556
Copy link
Collaborator

Thanks everyone for the inputs, at this time we know the root cause of the issue in upstream. I am going to lock this issue to avoid some noise. I will reopen the issue once a fix has been made.

@microsoft microsoft locked as spam and limited conversation to collaborators Jul 13, 2022
@deepak1556 deepak1556 added the upstream-issue-linked This is an upstream issue that has been reported upstream label Jul 13, 2022
@deepak1556 deepak1556 modified the milestones: July 2022, August 2022 Jul 26, 2022
@joaomoreno joaomoreno modified the milestones: September 2022, Backlog Sep 2, 2022
@bpasero bpasero moved this to 🏃 In Progress in VSCode Electron Integration Jul 24, 2023
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2024
@bpasero bpasero modified the milestones: Backlog, May 2024 May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member dialogs Issues with native and custom dialogs electron Issues and items related to Electron electron-17-update Issues related to electron 17 update linux Issues with VS Code on Linux native-file-dialog Issues with native file dialog on-testplan upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.