Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable extension action on setting and make setting read only when it is overridden #141462

Open
meganrogge opened this issue Jan 25, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues
Milestone

Comments

@meganrogge
Copy link
Contributor

Testing #141320

When I toggle this setting, nothing happens. Maybe when an extension overrides the value of a setting, we should make that checkbox read only?

Screen Shot 2022-01-25 at 11 33 38 AM

When I right clicked the setting, I expected to be able to disable the extension that is overriding its value. Have there been discussions about that?

@meganrogge meganrogge changed the title Disable extension or have user override Disable extension action on setting and make setting read only when it is overridden Jan 25, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jan 25, 2022
@rzhao271 rzhao271 added this to the January 2022 milestone Jan 25, 2022
@rzhao271
Copy link
Contributor

I'm able to see the terminal appearance change on Windows when toggling the checkbox. Maybe it's that there's a long delay between when the setting is toggled and when the appearance changes?

An option to disable the extension would be interesting. I'd rather first work on supporting language overrides, considering how some settings can be overridden per language.

@rzhao271 rzhao271 modified the milestones: January 2022, Backlog Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

2 participants