Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Settings editor default override indicator #141320

Closed
2 tasks done
rzhao271 opened this issue Jan 24, 2022 · 0 comments
Closed
2 tasks done

Test: Settings editor default override indicator #141320

rzhao271 opened this issue Jan 24, 2022 · 0 comments

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Jan 24, 2022

Refs: #137943

Complexity: 2

Create Issue


  1. Create a new extension that contributes a configurationDefaults. An example is at https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults, but don't make the override language-specific, because language overrides aren't displayed properly in the Settings editor yet. An alternative to creating a new extension is to update an existing extension to add a configurationDefaults contribution. Note that the contribution only affects the package.json file, and no changes need to be made in TypeScript files.
  2. Run the extension, and look for the overridden setting in the Settings editor.
  3. For that setting, the Settings editor should have an indicator showing the default value was overridden by an extension.

Something else to check is whether the behaviour of the override indicator makes sense when switching between the User and Workspace scopes. An example setting that is modifiable on both scopes is emmet.excludeLanguages: string[].

@ghost ghost assigned jrieken and gregvanl Jan 25, 2022
@jrieken jrieken removed their assignment Jan 25, 2022
@meganrogge meganrogge assigned meganrogge and unassigned gregvanl Jan 25, 2022
@meganrogge meganrogge removed their assignment Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants