Reapply badclient commit

Fixes #120781 Add second file this time
microsoft · Apr 8, 2021 · 604b950 · 604b950
1 parent 3702538
commit 604b950
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/extensions/typescript-language-features/src/tsServer/serverError.ts b/extensions/typescript-language-features/src/tsServer/serverError.ts
@@ -39,13 +39,15 @@ export class TypeScriptServerError extends Error {
 			"TypeScriptRequestErrorProperties" : {
 				"command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
 				"serverid" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
-				"sanitizedstack" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
+				"sanitizedstack" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
+				"badclient" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
 			}
 		*/
 		return {
 			command: this.serverCommand,
 			serverid: this.serverId,
 			sanitizedstack: this.sanitizedStack || '',
+			badclient: /\bBADCLIENT\b/.test(this.stack || ''),
 		} as const;
 	}
 

diff --git a/extensions/typescript-language-features/src/utils/telemetry.ts b/extensions/typescript-language-features/src/utils/telemetry.ts
@@ -14,7 +14,7 @@ interface PackageInfo {
 }
 
 export interface TelemetryProperties {
-	readonly [prop: string]: string | number | undefined;
+	readonly [prop: string]: string | number | boolean | undefined;
 }
 
 export interface TelemetryReporter {