Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix: add "type": "module" #419

Closed
wants to merge 1 commit into from
Closed

Conversation

jedwards1211
Copy link

Link to relevant issue

This pull request resolves #418

Description of changes

@hawkticehurst
Copy link
Member

hawkticehurst commented Nov 21, 2022

Thanks for the issue/PR @jedwards1211!

Changing the project to be type: module means a bunch of build scripts and configs need to be updated to use ESM (thus all the CI failures).

I'm actually going to close this PR because I have a similar PR (#421) that will resolve this exact issue. I was working on it a few weeks back and then got pulled to work on something different –– but I'm a bit further along on updating everything to be ESM compatible so I'll continue finishing that in my branch.

@jedwards1211
Copy link
Author

Awesome, thanks! I should have known it wouldn't be as simple as changing package.json, I hadn't gotten around to looking at the build status

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when using "moduleResolution": "NodeNext" because "type": "module" is missing
2 participants