This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Add basic component usage guidelines #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @albertelo |
miguelsolorio
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Some minor feedback on the examples but nothing that is a shipping blocker. These guidelines are a HUGE upgrade that make the extension guidelines look weak 😄 great work all around as this is crucial work for people using the toolkit.
hawkticehurst
approved these changes
Feb 4, 2022
daviddossett
added a commit
that referenced
this pull request
Feb 18, 2022
* Update button `disabled` attribute logic (#323) Description of changes Update logic for setting the `disabled` attribute value in the button component to fix a cross-browser bug. * Add basic component usage guidelines (#322) * Add badge and button guidelines without images * Add checkbox guidelines * Add divider guidelines * Add badge artwork * Update badge sections * Fix image * Update badge image * Add hero assets for all components * More guideline updates * More do/don'ts * Add radio and tag guidance * Add text field guidelines * Polish docs * Remove unused image * Remove unused image * Update assets structure * Fix progress ring corner radius * Fix images paths * Update button guidelines * Add link to button guidelines * Grammar fixes * Clarify text field guidelines * Grammar * PR feedback * Fix button images resolution * Update badge artwork. Add button artwork * Finish button artwork * Add checkbox artwork * Fix button size in table * More image res fixes * Add data grid and divider artwork * Add dropdown artwork * Add link artwork * Add panels guidelines * Add progress ring artwork * Add radio group artwork * Add missing alt text to radio image markdown * Add tag artwork * Add text area artwork * Add text field artwork * Fix missing badge artwork and alt text * Fix badge border radius * Add icon button example * PR feedback: update checkbox, data grid and dropdown * More PR feedback * Update basic example titles * Fix panel size * Initial commit * Try forcing scrollbar background with !important * FIx high contrast theme
|
Thanks for this work! Is this live already? |
|
@albertelo yep! Look at any of our component docs and you should see these guidelines 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to relevant issue
This pull request partly resolves #126
Description of changes
This PR provides an initial set of lightweight usage guidelines for each component in the form of simple do/don't examples. It also adds an image to each component's
READMEto give a quick preview of what each component looks like.To do:
/assetsExample