fix: tag non-stable settings with new system #24287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Oct 10, 2024
rzhao271
added
debt
rzhao271
commented
Oct 10, 2024
| @@ -677,7 +675,8 @@ | |||
| "scope": "resource", | |||
| "type": "boolean", | |||
| "tags": [ | |||
| "experimental" | |||
| "experimental", | |||
| "onExP" | |||
There was a problem hiding this comment.
I just realized that VS Code stable wouldn't recognize the onExP tag, so I'm keeping the experimental tag for now instead of changing it to the new preview tag.
karthiknadig
requested review from
luabud and
cwebster-99
and removed request for
anthonykim1
luabud
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some setting tags as follows:
python.missingPackage.severitysetting considering the setting does not seem to be experimental and that the setting does not seem to be part of any experiment.python.locatorsetting considering the setting is both experimental (based on its description) and part of an experiment.python.terminal.shellIntegration.enabled, considering it is a non-stable setting that does not seem to be part of an experiment.python.REPL.sendToNativeREPLconsidering it is part of an experiment.