Allow pytest to use correct interpreter from getActiveInterpreter #24233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
debt
anthonykim1
removed
the
debt
anthonykim1
commented
Oct 3, 2024
| @@ -34,6 +35,7 @@ export class PytestTestDiscoveryAdapter implements ITestDiscoveryAdapter { | |||
| private readonly outputChannel: ITestOutputChannel, | |||
| private readonly resultResolver?: ITestResultResolver, | |||
| private readonly envVarsService?: IEnvironmentVariablesProvider, | |||
| private readonly interpreterService?: IInterpreterService, | |||
There was a problem hiding this comment.
wanted to avoid dependency injection here - bit difficult since there are listener and event handlers like onDidChangeInterpreters attached.
We could also partially avoid using configService for: path = this.configService.getSettings(resource).pythonPath;
- Rather just make an API to get getting with resource without configService would be cleaner.
There was a problem hiding this comment.
Don't need to plumb the service through all layers. We can just pass the interpreter into the various layers.
|
Opening PR #24250 - running into lots of merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24122
Related: #24190, #24127
I think the culprit was we were not passing in interpreter when we call createActivatedEnvironment.
/cc @eleanorjboyd