Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await on promises #23802

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Await on promises #23802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6b6f8
Await on promises
DonJayamanne Jul 12, 2024
ad51607
Update version
DonJayamanne Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client/pythonEnvironments/base/locators/composite/envsCollectionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ export class EnvsCollectionService extends PythonEnvsWatcher<PythonEnvCollection
const validCondaInfoEnvs = new Set<string>();
const duplicate = new Set<string>();
// Duplicate, invalid conda environments.
Promise.all(
await Promise.all(
(info?.envs || []).map(async (e) => {
if (duplicate.has(e)) {
condaTelemetry.condaInfoEnvsDuplicate += 1;
Expand All @@ -461,7 +461,7 @@ export class EnvsCollectionService extends PythonEnvsWatcher<PythonEnvCollection

// Conda env_dirs
const validEnvDirs = new Set<string>();
Promise.all(
await Promise.all(
// eslint-disable-next-line camelcase
(info?.envs_dirs || []).map(async (e) => {
if (await pathExists(e)) {
Expand Down Expand Up @@ -736,7 +736,7 @@ export class EnvsCollectionService extends PythonEnvsWatcher<PythonEnvCollection

// Intent is to capture time taken for discovery of all envs to complete the first time.
sendTelemetryEvent(EventName.PYTHON_INTERPRETER_DISCOVERY, elapsedTime, {
telVer: 4,
telVer: 5,
nativeDuration,
workspaceFolderCount: (workspace.workspaceFolders || []).length,
interpreters: this.cache.getAllEnvs().length,
Expand Down
Loading